-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests-stdenv-gcc-stageCompare: cleanup #316011
base: master
Are you sure you want to change the base?
Conversation
d971036
to
e45cc3a
Compare
That's a bit out of scope for my level of knowledge regarding bootstrapping |
@SuperSandro2000, OK, sorry for the ping. I’m relatively new to the Nix community so I don’t know much about other members’ area of expertise. Do you happen to know someone else who can properly review this? Would be nice if someone was willing to work on fixing this test case since I’m currently out of capacity for low-level stdenv stuff with #314920 and other PRs 😅 |
@wegank, could you help me with triaging this PR? Who is responsible for this part of Nixpkgs? The author of the original PR #209870 deleted GitHub account (amjoseph-nixpkgs)… Should I move #314920 (comment) to a standalone issue? |
The change looks fine. My suggestion would be to remove
Side note: --- a/pkgs/build-support/setup-hooks/reproducible-builds.sh
+++ b/pkgs/build-support/setup-hooks/reproducible-builds.sh
@@ -8,2 +8,3 @@ NIX_CFLAGS_COMPILE="${NIX_CFLAGS_COMPILE:-} -frandom-seed=$(
randomseed="${outbase:0:10}"
+ randomseed=not-random-at-all
echo $randomseed |
Description of changes
Minor cleanup of the
tests-stdenv-gcc-stageCompare
. Note that the test itself is currently silently broken, see #314920 (comment). This PR does not fix that.Parent PR:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.